-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functions to control the cache eviction #31
Open
gobinathsr
wants to merge
4
commits into
tuner
Choose a base branch
from
pacer_one
base: tuner
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To show up logs per second
This reverts commit d38d987.
Assigned credit for a pacer period is utilized without considering the bytes in flight. Hence bytes flight increases a lot above the allowed maximum threshold level and leading to the cache eviction & leading to cache miss. Fix info: Added the below functions to control the cache eviction 1. is_credit_available() - When credit availably checked, also checking bytes in flight is with in the maximum allowed bytes Default enabled with the macro SPDK_NVMF_RDMA_IO_PACER_ALLOW_WITHIN_CREDIT_ONLY 2. is_entry_size_within_limit() - When processing the request from the pacer check if the request size is within in the allowed bytes range Default disabled with the macro SPDK_NVMF_RDMA_IO_PACER_ALLOW_IO_WITHIN_AVAIL - Reason to allow processing a single request to consider the slow disk/other slowness in processing the request Added the macros to configure the tuner type and the proposals. Hence with the change will send the parameters from the test script to configure dynamically. [Features/Functional areas and/or component interfaces affected] General SPDK [Whether the change affects how hardware is programmed] Yes - Configures request out of pacer queue to be processed Local testing: Tested with Tuner2 - Test14 test case and below is the test result test_14 CPU mask: 0xF0 Num cores:4 IO pacer period:5600 Adjusted period:22400 ./test_NoArg.sh: line 336: 708492 Terminated tail -f > rpc_pipe | QD | BW | BW Max | WIRE BW | AVG LAT, us | BW STDDEV | L3 Hit Rate | Bufs in-flight (MiB) | Pacer period, us | 256 | 185.6 | 191.0 | 188.9947 | 2891.1 | .6 | 99.3 | 29.6 (3.7) | 22.5
gobinathsr
changed the title
Test with updating the comment info
Added functions to control the cache eviction
Nov 9, 2020
Pls ignore the first 3 commit added for testing with pull request. On merging, will squash and merge as single commit. |
It seems multiple changes are there in single patch.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions to control the cache eviction
Root Cause:
Assigned credit for a pacer period is utilized without considering the bytes in flight.
Hence bytes flight increases a lot above the allowed maximum threshold level and leading to the cache eviction & leading to cache miss.
Fix info:
Added the below functions to control the cache eviction
is_credit_available() - When credit availably checked, also checking bytes in flight is with in the maximum allowed bytes
Default enabled with the macro SPDK_NVMF_RDMA_IO_PACER_ALLOW_WITHIN_CREDIT_ONLY
is_entry_size_within_limit() - When processing the request from the pacer check if the request size is within in the allowed bytes range
Default disabled with the macro SPDK_NVMF_RDMA_IO_PACER_ALLOW_IO_WITHIN_AVAIL - Reason to allow processing a single request to consider the slow disk/other slowness in processing the request
Added the macros to configure the tuner type and the proposals. Hence with the change will send the parameters from the test script to configure dynamically.
[Features/Functional areas and/or component interfaces affected]
General SPDK
[Whether the change affects how hardware is programmed]
Yes - Configures request out of pacer queue to be processed
Local testing:
Tested with Tuner2 - Test14 test case and below is the test result
test_14
CPU mask: 0xF0 Num cores:4 IO pacer period:5600 Adjusted period:22400
./test_NoArg.sh: line 336: 708492 Terminated tail -f > rpc_pipe
| QD | BW | BW Max | WIRE BW | AVG LAT, us | BW STDDEV | L3 Hit Rate | Bufs in-flight (MiB) | Pacer period, us
| 256 | 185.6 | 191.0 | 188.9947 | 2891.1 | .6 | 99.3 | 29.6 (3.7) | 22.5