-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Push artifacts versions to Network Operator repo #37
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 12479808379Details
💛 - Coveralls |
.github/workflows/fork-ci.yaml
Outdated
if [ -z "${IS_BETA}" ]; then | ||
echo "BRANCH_NAME=master" >> $GITHUB_ENV | ||
else | ||
echo "BRANCH_NAME="$DOCKER_TAG" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BRANCH_NAME here will be in format 'v25.01.x'? It looks it take the tag as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SR-IOV we use the format like "network-operator-24.1.0-beta.3".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is going to be opened on Network-Operator repo.
The branch there should be master
for beta
, and eg. v24.10.x
for rc and GA
.github/workflows/fork-ci.yaml
Outdated
git config user.email [email protected] | ||
|
||
git checkout -b feature/update-sriov-tags-to-$DOCKER_TAG | ||
sed -Ei "s/(version: )network-operator-.+/\\1$DOCKER_TAG/g" hack/release.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more changes here needed according to existing "draft-image-builder"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed now
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
No description provided.