ci: Push artifacts versions to Network Operator repo #37
Conversation
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 12545107010Details
💛 - Coveralls |
.github/workflows/fork-ci.yaml
Outdated
| if [ -z "${IS_BETA}" ]; then | ||
| echo "BRANCH_NAME=master" >> $GITHUB_ENV | ||
| else | ||
| echo "BRANCH_NAME="$DOCKER_TAG" >> $GITHUB_ENV |
There was a problem hiding this comment.
BRANCH_NAME here will be in format 'v25.01.x'? It looks it take the tag as is
There was a problem hiding this comment.
In SR-IOV we use the format like "network-operator-24.1.0-beta.3".
There was a problem hiding this comment.
The PR is going to be opened on Network-Operator repo.
The branch there should be master for beta, and eg. v24.10.x for rc and GA
.github/workflows/fork-ci.yaml
Outdated
| git config user.email [email protected] | ||
|
|
||
| git checkout -b feature/update-sriov-tags-to-$DOCKER_TAG | ||
| sed -Ei "s/(version: )network-operator-.+/\\1$DOCKER_TAG/g" hack/release.yaml |
There was a problem hiding this comment.
There are more changes here needed according to existing "draft-image-builder"
|
|
||
| git checkout -b feature/update-sriov-tags-to-$DOCKER_TAG | ||
| yq -i e '.SriovNetworkOperator.repository |= "${{ env.DOCKER_REGISTRY }}"' hack/release.yaml | ||
| yq -i e '.SriovNetworkOperator.version |= "${{ env.DOCKER_TAG }}"' hack/release.yaml |
There was a problem hiding this comment.
Some steps are different from current draft-image-builder.jenkinsfile
- Need to sync the helm chart
- When is the Network Operator image built and release.yaml updated with it?
- When is the Chart.yaml updated?
- All GA handling (different repositories)
There was a problem hiding this comment.
Some steps are different from current
draft-image-builder.jenkinsfile
- Need to sync the helm chart
done- When is the Network Operator image built and release.yaml updated with it?
it will be done in network operator action- When is the Chart.yaml updated?
@rollandf could you please add more details regarding this comment?- All GA handling (different repositories)
done
There was a problem hiding this comment.
Regarding chart.yaml, this is waht we have in draft-image-builder.jenkinsfile
def chart_file = './deployment/network-operator/Chart.yaml'
def ChartData = readYaml file: "${chart_file}"
ChartData.version = "${(version.substring(1))}"
ChartData.appVersion = "${version}"
writeYaml file: "${chart_file}", data: ChartData, overwrite: true
There was a problem hiding this comment.
@e0ne I am OK to merge this and iterate on follow ups
There was a problem hiding this comment.
Regarding chart.yaml, this is waht we have in
draft-image-builder.jenkinsfile
it should be fixed in package-and-push-helm-chart job or some other which merges code into the repo
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
No description provided.