fix: use psycopg text array decoding in wal2json messages #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudovisk
force-pushed
the
main
branch
2 times, most recently
from
f4267b1
to
35e5550
Compare
edgarrmondragon
approved these changes
Aug 27, 2024
|
Thanks @hudovisk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack thread: https://meltano.slack.com/archives/C06A1MD6A6L/p1724619858505739
When using log based replication, the wal2json output for columns of array types returns a string encoded in sql format.
Ex: '{a,b}'
The records produced by the tap in this sutation fails the target schema validation, since the schema is of type array and the value is a string.
I included a test case for it. Please feel free to modify the PR, I am by no means a python developer.
Related: