New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add browser authentication #46

Merged

edgarrmondragon merged 2 commits into MeltanoLabs:main from haleemur:add-browser-authentication

Sep 20, 2024

Contributor

haleemur commented Sep 20, 2024 •

edited

Loading

Description

Copy code over from target-snowflake feat: Add new config parameter private_key target-snowflake#260, now there is parity between how the target & tap can connect to snowflake (3 ways: password, key pair & browser authentications)
This refactor uses Enum for auth_method for greater type safety.


          copy code over from target-snowflake & add broser authentication

b90db8a

haleemur changed the title ~~copy code over from target-snowflake & add broser authentication~~ feat: Add browser authentication

edgarrmondragon reviewed

View reviewed changes

tap_snowflake/tap.py Outdated Show resolved Hide resolved


          Update tap_snowflake/tap.py

0937cf5

edgarrmondragon approved these changes

View reviewed changes

edgarrmondragon merged commit c519d8e into MeltanoLabs:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet