Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

131 add spring rest docs #132

Merged
merged 6 commits into from
Dec 11, 2023
Merged

131 add spring rest docs #132

merged 6 commits into from
Dec 11, 2023

Conversation

megymj
Copy link
Member

@megymj megymj commented Dec 7, 2023

* request DTO 분리
* FollowControllerDocsTest 작성
* request DTO 분리(Controller, Service)
* AuthControllerDocsTest 작성
* asciidoc 내용 추가
* AuthServiceExceptionTest 제거 -> Mocking에 대해 더 이해를 한 뒤 추후 진행할 예정
* getFollowUserInfo 로직에 대한 FollowingControllerDocsTest, FollowingControllerTest 작성
* asciidoc 내용 추가
* dto 객체들을 service layer로 이동
@megymj megymj self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #132 (c9e6261) into develop (3a88c32) will decrease coverage by 0.33%.
Report is 1 commits behind head on develop.
The diff coverage is 77.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #132      +/-   ##
=============================================
- Coverage      79.52%   79.20%   -0.33%     
- Complexity       149      151       +2     
=============================================
  Files             24       25       +1     
  Lines            723      726       +3     
  Branches          51       49       -2     
=============================================
  Hits             575      575              
- Misses           141      143       +2     
- Partials           7        8       +1     
Files Coverage Δ
...apstone/menjil/domain/auth/api/AuthController.java 100.00% <100.00%> (ø)
...one/menjil/domain/follow/api/FollowController.java 100.00% <100.00%> (ø)
...one/menjil/domain/main/api/MainPageController.java 100.00% <100.00%> (ø)
...enjil/domain/main/application/MainPageService.java 100.00% <100.00%> (ø)
...ch/capstone/menjil/global/exception/ErrorCode.java 100.00% <100.00%> (ø)
...apstone/menjil/global/exception/ErrorIntValue.java 100.00% <100.00%> (ø)
.../capstone/menjil/global/exception/SuccessCode.java 100.00% <100.00%> (ø)
...njil/domain/following/api/FollowingController.java 57.14% <50.00%> (+42.85%) ⬆️
...domain/following/application/FollowingService.java 61.76% <33.33%> (ø)
...enjil/domain/follow/application/FollowService.java 84.21% <66.66%> (+1.85%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

@megymj megymj merged commit cbedc00 into develop Dec 11, 2023
1 of 3 checks passed
@megymj megymj deleted the 131-add-spring-rest-docs branch December 11, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant