Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to main #136

Merged
merged 21 commits into from
Dec 11, 2023
Merged

Develop to main #136

merged 21 commits into from
Dec 11, 2023

Conversation

megymj
Copy link
Member

@megymj megymj commented Dec 11, 2023

Develop to main

  1. Spring Rest Docs 적용, Request Dto 세분화
  1. CI/CD 단순화

megymj and others added 21 commits October 23, 2023 16:04
Chore chat(협업 진행시 일부 수정 및 추가한 내용)
…vice

test: MessageRatingService 테스트 코드 수정
* Remove domain of 'UserRole'
* Remove OptionInfo and add 4 columns to the domain of User
* Update test codes
* request DTO 분리
* FollowControllerDocsTest 작성
* request DTO 분리(Controller, Service)
* AuthControllerDocsTest 작성
* asciidoc 내용 추가
* AuthServiceExceptionTest 제거 -> Mocking에 대해 더 이해를 한 뒤 추후 진행할 예정
* getFollowUserInfo 로직에 대한 FollowingControllerDocsTest, FollowingControllerTest 작성
* asciidoc 내용 추가
* dto 객체들을 service layer로 이동
@megymj megymj self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #136 (bbe9d83) into main (53cf17c) will increase coverage by 0.79%.
Report is 1 commits behind head on main.
The diff coverage is 81.03%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #136      +/-   ##
============================================
+ Coverage     78.40%   79.20%   +0.79%     
- Complexity      148      151       +3     
============================================
  Files            24       25       +1     
  Lines           727      726       -1     
  Branches         52       49       -3     
============================================
+ Hits            570      575       +5     
+ Misses          150      143       -7     
- Partials          7        8       +1     
Files Coverage Δ
...apstone/menjil/domain/auth/api/AuthController.java 100.00% <100.00%> (ø)
...tone/menjil/domain/chat/api/MessageController.java 10.81% <ø> (ø)
.../domain/chat/application/MessageRatingService.java 100.00% <100.00%> (ø)
...menjil/domain/chat/application/MessageService.java 53.93% <ø> (+4.95%) ⬆️
...one/menjil/domain/follow/api/FollowController.java 100.00% <100.00%> (ø)
...one/menjil/domain/main/api/MainPageController.java 100.00% <100.00%> (ø)
...enjil/domain/main/application/MainPageService.java 100.00% <100.00%> (ø)
...ch/capstone/menjil/global/exception/ErrorCode.java 100.00% <100.00%> (ø)
...apstone/menjil/global/exception/ErrorIntValue.java 100.00% <100.00%> (ø)
.../capstone/menjil/global/exception/SuccessCode.java 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

@megymj megymj merged commit de67728 into main Dec 11, 2023
6 checks passed
@megymj megymj deleted the develop branch December 11, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant