-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Component Modal #291
Merged
Ar3secchim
merged 22 commits into
Mentor-Cycle:dev
from
Ar3secchim:refactor/componentModal
Aug 3, 2023
Merged
Refactor: Component Modal #291
Ar3secchim
merged 22 commits into
Mentor-Cycle:dev
from
Ar3secchim:refactor/componentModal
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveirabalsa
requested changes
Jul 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oi @Ar3secchim, tem alguns conflitos de merge
Ar3secchim
requested review from
oliveirabalsa
and removed request for
oliveirabalsa
July 23, 2023 15:51
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
oliveirabalsa
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Description:
Este pull request tem como objetivo realizar uma refatoração completa do componente de modal do projeto, adicionando o Modal de Alert,utilizando a biblioteca Radix UI para melhorar a usabilidade, acessibilidade e a manutenção do código.
✅ Checklist:
🔄 Main changes:
props
para cada componente de modal.ModalRoot
, seguindo as diretrizes de design da aplicação. Isso garante que o modal se integre harmoniosamente ao restante da interface e que as mudanças pontuais de estilo de cada componente fica de responsabilidade do tal.ModalRoot
.ModalAlert
na lógica do contextApi de modal.Additional notes:
Separei o componente
Modal
em pequenos componentes. No qual são partes que podem ser customizadas por si só, sendo assim reutilizadas em outros componentes.Esse é o componente
Modal
que tem como responsabilidade apenas de juntas todas as outras partes (componentes menores).Componente
ModalAlert
que vai substituir a lib sweetalert. Criado a partir doModalRoot
.Componente
💡 Assim que essa PR for concluida faço as substituição da sweetalert pelo ModalAlert #240ModalAlert
renderizado: