Highlight: use PathPolyline instead of PathMove/PathLine #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlighting geometries with lots of vertices was slow because a shape path with many PathMove/PathLine was apparently doing loads of internal updates when constructing it. Qt introduced PathPolyline in a latter qt5 release (5.14) which makes parsing of dynamically constructed complex paths much more efficient.
PeterPetrik
approved these changes
Oct 11, 2023
PeterPetrik
added
the
ready-for-testing
|
@jozef-budac can you please test this one? android: https://github.com/MerginMaps/input/suites/17110071391/artifacts/977405511 |
|
I can confirm the loading of such a polygons is very fast |
tomasMizera
removed
the
ready-for-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-861n417r8
Highlighting geometries with lots of vertices was slow because a shape path with many PathMove/PathLine was apparently doing loads of internal updates when constructing it. Qt introduced PathPolyline in a latter qt5 release (5.14) which makes parsing of dynamically constructed complex paths much more efficient.
On desktop build: a polygon with 15K vertices was taking 5-10 seconds to highlight, now it is less than a second.
Fixes #833