Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapcanvas UX issues #2864

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix mapcanvas UX issues #2864

merged 3 commits into from
Oct 23, 2023

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Oct 19, 2023

Update, ready for review

These things are fixed/added:

  • The formula for calculating vector distance was missing + πŸ€¦πŸ»β€β™‚οΈ πŸ˜ƒ , resulting in wrong distances calculated when you dragged the map vertically
  • Added distance threshold for double clicks - now the second click must be within a threshold from the first point.
  • Added time elapsed threshold for detecting drag movement - sometimes, if you move a map just by a tiny bit to fit the point, you might not exceed the distance threshold to detect the movement as a drag. It would be detected as a simple tap. This caused unexpected actions while recording new/updating existing geometries. Now to detect the drag gesture we use a combination of a distance threshold and a time threshold ("how long the tap lasted")
  • Thresholds are now read from Qt built-in Application.styleHints.xyz

  • Added distance threshold for double clicks
  • Make the drag.threshold smaller when digitizing -> when a user is digitizing, they need to pan the map by small distances that sometimes do not meet the drag.threshold. We need to find a better threshold and test it on all platforms.

@tomasMizera tomasMizera added this to the 2.4.0 milestone Oct 19, 2023
@tomasMizera tomasMizera marked this pull request as ready for review October 21, 2023 19:50
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested iOS and it works nicely

@PeterPetrik PeterPetrik merged commit 08dfd59 into master Oct 23, 2023
10 of 11 checks passed
@PeterPetrik PeterPetrik deleted the make-digitizing-ux-nicer branch October 23, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants