-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML, Text, Spacer "other form widgets" + "show label" #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
changed the title
WIP: other form elements
HTML, Text, Spacer "other form widgets" + "show label"
Oct 23, 2023
PeterPetrik
added
the
ready-for-testing
Ready to be tested by testers crew - passed review by devs
label
Oct 23, 2023
unrelated test failure |
1 task
tomasMizera
reviewed
Oct 25, 2023
@jozef-budac this is ready for testing, also it would be good to add new elements to regression suite |
tomasMizera
approved these changes
Oct 26, 2023
Verified on Android, that HTML, Spacer, and text widget work with expressions. Interestingly, expressions for these widgets don't work in QGIS 3.32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2643
Added:
Screen.Recording.2023-10-23.at.9.31.40.mov
TODO
note for HTML we use QML Text, if we change rendering engine for preview-panel (#1259) we should use it here.