Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML, Text, Spacer "other form widgets" + "show label" #2867

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

PeterPetrik
Copy link
Contributor

@PeterPetrik PeterPetrik commented Oct 20, 2023

fix #2643

Added:

Screenshot 2023-10-20 at 15 54 47

Screen.Recording.2023-10-23.at.9.31.40.mov

TODO

  • make hline color gray and space similar to one in QGIS
  • fix when HTML/Text uses expressions
  • tests

note for HTML we use QML Text, if we change rendering engine for preview-panel (#1259) we should use it here.

@PeterPetrik PeterPetrik added enhancement FROZEN 🥶 do not merge before upcoming release labels Oct 20, 2023
@PeterPetrik PeterPetrik changed the title WIP: other form elements HTML, Text, Spacer "other form widgets" + "show label" Oct 23, 2023
@PeterPetrik PeterPetrik added the ready-for-testing Ready to be tested by testers crew - passed review by devs label Oct 23, 2023
@PeterPetrik
Copy link
Contributor Author

unrelated test failure

@PeterPetrik PeterPetrik removed the FROZEN 🥶 do not merge before upcoming release label Oct 24, 2023
app/qml/editor/inputrichtext.qml Outdated Show resolved Hide resolved
app/attributes/attributedata.cpp Show resolved Hide resolved
app/qml/editor/inputrichtext.qml Show resolved Hide resolved
app/qml/editor/inputspacer.qml Outdated Show resolved Hide resolved
app/qml/editor/inputspacer.qml Outdated Show resolved Hide resolved
app/qml/form/FeatureForm.qml Show resolved Hide resolved
@PeterPetrik
Copy link
Contributor Author

PeterPetrik commented Oct 25, 2023

@jozef-budac this is ready for testing, also it would be good to add new elements to regression suite

@jozef-budac
Copy link

Verified on Android, that HTML, Spacer, and text widget work with expressions. Interestingly, expressions for these widgets don't work in QGIS 3.32.

@PeterPetrik PeterPetrik merged commit 32a4a66 into master Oct 26, 2023
8 of 11 checks passed
@PeterPetrik PeterPetrik deleted the other_elems branch October 26, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for text and spacer widget
4 participants