-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving UX by hiding editing buttons for readers of a project #3682
Open
VitorVieiraZ
wants to merge
9
commits into
master
Choose a base branch
from
enhancementUiUx/readerCantEdit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anging Add button visibility for readers
Pull Request Test Coverage Report for Build 12256026569Details
💛 - Coveralls |
VitorVieiraZ
changed the title
WIP - Improving UX by hiding editing buttons for readers and guests of a project
Improving UX by hiding editing buttons for readers and guests of a project
Dec 10, 2024
VitorVieiraZ
changed the title
Improving UX by hiding editing buttons for readers and guests of a project
Improving UX by hiding editing buttons for readers of a project
Dec 10, 2024
tomasMizera
requested changes
Jan 6, 2025
@@ -59,6 +59,8 @@ struct MerginProjectMetadata | |||
{ | |||
QString name; | |||
QString projectNamespace; | |||
QString role; | |||
QList<QString> writersnames; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed here
@@ -48,6 +48,8 @@ Item { | |||
function setupProjectOpen( projectPath ) { | |||
if ( projectPath === __activeProject.localProject.qgisProjectFilePath ) | |||
{ | |||
// update user's role in project ( in case user has changed ) | |||
__activeProject.updateUserRoleInActiveProject() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is giving me qml error, the function is not Q_INVOKABLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in
Reader
role, editing buttons are no longer visible to user. These buttons include:Main
Add
button and the one within the features list.Add feature
button and its variations.Edit feature
button and its variations.Edit geometry
button.Resolves #3174