Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail in last PR regarding the use of json module #225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ValentinBuira
Copy link
Contributor

There is a typo in my last PR regarding the use of json module

I used json.loads with a s instead of json.load that support de serializing python object and not string

Every use of workspace_service failed in the plugin because of that

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12198737480

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.317%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/client.py 0 1 0.0%
Totals Coverage Status
Change from base Build 12176048796: 0.0%
Covered Lines: 3275
Relevant Lines: 4129

💛 - Coveralls

Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is ok. We need to update tests to catch these errors for workspace_service method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants