Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Switch project sources from GPKG to Postgre based on DBSync config #536
base: master
Are you sure you want to change the base?
[WIP] Switch project sources from GPKG to Postgre based on DBSync config #536
Changes from 1 commit
a2173ec
5052b07
7556c0e
b81ecab
909c1ea
3d86853
9deaf24
733e17c
9c318fa
945afda
b1f7a46
fd0c3a0
72e3f59
de3af74
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try using QgsProviderRegistry.instance().decodeUri() instead of using regexps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not store reference to QgsProject.instance() to self.qgis_project - simply use QgsProject.instance() where needed, it will be easier to read the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have all the conversion code (+Connection class) outside of the GUI code, in a separate python file, so we can possibly also run auto-tests checking the conversion functionality...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't need to read the full project - we don't need to resolve the layers, it will be much faster to read it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we do a better check for the URI match? e.g. if the sync_file is "data.gpkg" and there's also "backup/data.gpkg" file in the project, or maybe the QGIS project is also referencing a file outside of the MM project directory?