Account index and key index fix in MeshWallet #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MeshWallet
is targeted to have the ability to access an account at any index generated from an HD mnemonic (or a root private key). But it was not able to access any account other than the first one.MeshWallet
is now able to utilize the providedaccountIndex
andkeyIndex
when an instance is created, which was not the case before, becausegetAddressesFromWallet()
was getting called before setting those indexes.MeshWallet
'ssignData()
, theaccountIndex
andkeyIndex
are now being passed to the EmbeddedWallet's signData().Affect components
@meshsdk/common
@meshsdk/contract
@meshsdk/core
@meshsdk/core-csl
@meshsdk/core-cst
@meshsdk/provider
@meshsdk/react
@meshsdk/transaction
@meshsdk/wallet
Type of Change
Related Issues
Not any
Checklist
npm run test
)npm run build
)