fix: port isSerializedKeyringsArray function

MetaMask · Jan 24, 2024 · 214cf7f · 214cf7f
1 parent 7e4a5f6
commit 214cf7f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/packages/keyring-controller/src/KeyringController.ts b/packages/keyring-controller/src/KeyringController.ts
@@ -31,6 +31,7 @@ import {
   hasProperty,
   isObject,
   isValidHexAddress,
+  isValidJson,
   remove0x,
 } from '@metamask/utils';
 import { Mutex } from 'async-mutex';
@@ -442,7 +443,7 @@ function isSerializedKeyringsArray(
   return (
     typeof array === 'object' &&
     Array.isArray(array) &&
-    array.every((value) => value.type && value.data)
+    array.every((value) => value.type && isValidJson(value.data))
   );
 }
 

diff --git a/packages/keyring-controller/tests/mocks/mockEncryptor.ts b/packages/keyring-controller/tests/mocks/mockEncryptor.ts
@@ -1,5 +1,3 @@
-import type { Json } from '@metamask/utils';
-
 import type { ExportableKeyEncryptor } from '../../src/KeyringController';
 
 export const PASSWORD = 'password123';
@@ -19,7 +17,7 @@ export const MOCK_HEX = '0xabcdef0123456789';
 const MOCK_KEY = Buffer.alloc(32);
 const INVALID_PASSWORD_ERROR = 'Incorrect password.';
 
-let cacheVal: Json;
+let cacheVal: string;
 
 export default class MockEncryptor implements ExportableKeyEncryptor {
   // TODO: Replace `any` with type
@@ -36,13 +34,13 @@ export default class MockEncryptor implements ExportableKeyEncryptor {
       throw new Error(INVALID_PASSWORD_ERROR);
     }
 
-    return cacheVal ?? {};
+    return JSON.parse(cacheVal) ?? {};
   }
 
   // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   async encryptWithKey(_key: unknown, dataObj: any) {
-    cacheVal = dataObj;
+    cacheVal = JSON.stringify(dataObj);
     return {
       data: MOCK_HEX,
       iv: 'anIv',