refactor: remove addNewAccount code repetition

MetaMask · Jan 26, 2024 · 84d9cf4 · 84d9cf4
1 parent 7db3917
commit 84d9cf4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/packages/keyring-controller/jest.config.js b/packages/keyring-controller/jest.config.js
@@ -19,7 +19,7 @@ module.exports = merge(baseConfig, {
     global: {
       branches: 95.17,
       functions: 100,
-      lines: 99.22,
+      lines: 99.21,
       statements: 99.22,
     },
   },

diff --git a/packages/keyring-controller/src/KeyringController.ts b/packages/keyring-controller/src/KeyringController.ts
@@ -605,17 +605,13 @@ export class KeyringController extends BaseController<
       };
     }
 
-    await this.addNewAccountForKeyring(primaryKeyring);
-    const newAccounts = await this.getAccounts();
-
+    const addedAccountAddress = await this.addNewAccountForKeyring(
+      primaryKeyring,
+    );
     await this.verifySeedPhrase();
 
-    this.updateIdentities(newAccounts);
-    const addedAccountAddress = newAccounts.find(
-      (selectedAddress: string) => !oldAccounts.includes(selectedAddress),
-    );
+    this.updateIdentities(await this.getAccounts());
 
-    assertIsStrictHexString(addedAccountAddress);
     return {
       keyringState: this.#getMemState(),
       addedAccountAddress,