Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for unsupported keyring methods #3831

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jan 24, 2024

Explanation

This PR adds some test coverage for cases where the requested method is not supported by the keyring linked with the provided account. These are the methods tested:

  • removeAccount
  • exportAccount
  • getEncryptionPublicKey
  • decryptMessage
  • signMessage
  • signPersonalMessage
  • signTypedMessage
  • signTransaction

The remaining methods related to user operations will be addressed in another PR, as they also need more refactoring to be aligned with how tests for other methods are written.

References

Changelog

No documentable changes

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito requested a review from a team as a code owner January 24, 2024 13:21
@mikesposito mikesposito force-pushed the chore/bump-unsupported-methods-coverage branch 4 times, most recently from be84a2b to 9c817d2 Compare January 24, 2024 14:09
@mikesposito mikesposito force-pushed the chore/bump-unsupported-methods-coverage branch from 9c817d2 to a832c36 Compare January 24, 2024 14:11
@mikesposito mikesposito mentioned this pull request Jan 24, 2024
3 tasks
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikesposito mikesposito merged commit 3f05a94 into main Jan 24, 2024
136 checks passed
@mikesposito mikesposito deleted the chore/bump-unsupported-methods-coverage branch January 24, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants