fix: internal listeners infinite retry loop #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to cover this with tests |
mikesposito
commented
Nov 13, 2024
src/PollingBlockTracker.ts
Outdated
| @@ -54,6 +52,10 @@ export class PollingBlockTracker | |||
|
|
|||
| private readonly _setSkipCacheFlag: boolean; | |||
|
|
|||
| readonly #onLatestBlockInternalListeners: (( | |||
There was a problem hiding this comment.
Other class variables use private readonly _, but I suppose we'll want to change them sometime in the future.
I'm ok with aligning this with others for now if that looks better
Gudahtt
reviewed
Nov 13, 2024
Co-authored-by: Mark Stacey <[email protected]>
This reverts commit eb5514d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our block tracker implementation relies on the presence of listeners to establish whether the polling should be continued or stopped.
However, an internal listener is being added in the
getLatestBlockmethod, which will count as the other external listeners and will prevent the instance from stopping fetching new blocks. This creates an infinite loop in case the network is unreachable, because of the retry mechanism.This PR aims to fix this behavior by keeping track of internal listeners' references in order to exclude them from the listener's count
Fixes #163