Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: replace eth-query with @metamask/eth-query #107

Merged
merged 2 commits into from
Oct 12, 2023
Merged

deps: replace eth-query with @metamask/eth-query #107

merged 2 commits into from
Oct 12, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 22, 2023 •
edited
Loading

@legobeat legobeat mentioned this pull request Sep 22, 2023
Merged
5 tasks
@socket-security
Copy link

socket-security bot commented Sep 22, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-query 3.0.1 None +0 11.8 kB metamaskbot

@socket-security
Copy link

socket-security bot commented Sep 22, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore @metamask/[email protected]
@SocketSecurity ignore @metamask/[email protected]

@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore [email protected]

unmaintained ok

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 22, 2023
@legobeat legobeat mentioned this pull request Sep 22, 2023
Merged
2 tasks
@legobeat legobeat marked this pull request as ready for review September 22, 2023 23:09
@legobeat legobeat requested a review from a team as a code owner September 22, 2023 23:09
@legobeat legobeat requested review from a team September 22, 2023 23:10
@legobeat legobeat requested review from brad-decker and a team and removed request for a team September 26, 2023 02:03
@legobeat legobeat force-pushed the deps-metamask-eth-query branch 2 times, most recently from 8b149e3 to 08c3882 Compare September 28, 2023 07:32
mcmire
mcmire approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit 38f3aa2 into MetaMask:main Oct 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

@brad-decker brad-decker Awaiting requested review from brad-decker

@mikesposito mikesposito Awaiting requested review from mikesposito

@jpuri jpuri Awaiting requested review from jpuri

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire