Update new tests to destroy block tracker #156
Conversation
Certain middleware use a polling block tracker to retrieve the latest block. This type of block tracker has the ability to make a quick request in addition to polling, but doing so requires starting the poll loop and then immediately stopping it. This means that it is possible for the block tracker to be in a running state when a test that uses it ends. To avoid this, we need to make sure we completely shut down the block tracker at the end of each test. The ability to do this was added in a recent version of `eth-block-tracker`.
|
Putting this in a draft state because this PR is dependent upon MetaMask/eth-block-tracker#117 (otherwise we can't grab the Provider type from |
|
@mcmire this seems to be unblocked now |
|
@Gudahtt Hmm, these changes don't seem as useful as I thought. After running the test suite on this branch, I'm seeing the "Jest did not exit one second after the test run has completed" message from Jest, which I feel like these changes were intended to remove. I've played around with this a bit, and it seems that destroying the PollingBlockTracker doesn't kill the last |
Certain middleware use a polling block tracker to retrieve the latest block. This type of block tracker has the ability to make a quick request in addition to polling, but doing so requires starting the poll loop and then immediately stopping it. This means that it is possible for the block tracker to be in a running state when a test that uses it ends. To avoid this, we need to make sure we completely shut down the block tracker at the end of each test. The ability to do this was added in a recent version of
eth-block-tracker.