Skip to content

Commit

Permalink
fix: fix NFTs disappearing after killing app (#12529)
Browse files Browse the repository at this point in the history
## **Description**

PR to fix NFTs disappearing after the user closes the app

## **Related issues**

Fixes: #12523

## **Manual testing steps**

1. Go to to a network that is not (Ethereum/Linea) where you have NFTs
2. Import your NFT
3. Kill app
4. Open app again
5. Go to NFT tab
6. You should see your NFT

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/11ef5fe1-5a14-4f10-9e76-b65db4c519be


### **After**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/64cccd43-3ae7-4c27-989d-f842a68127a4


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
sahar-fehri authored Dec 5, 2024
1 parent 32843a4 commit 7db2099
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/core/Engine/Engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ export class Engine {
AccountsControllerSelectedEvmAccountChangeEvent,
],
}),
state: initialState.NftController,
});

const loggingController = new LoggingController({
Expand Down

0 comments on commit 7db2099

Please sign in to comment.