Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable protect modal in development #10110

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −0
Draft

chore: disable protect modal in development #10110

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08b0136
disable protect modal in development
dbrans Jun 25, 2024
ff400ca
create isDevelopment function
dbrans Jun 25, 2024
7fbada6
fix import
dbrans Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/UI/DrawerView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,11 @@ class DrawerView extends PureComponent {
};

renderProtectModal = () => {
const NODE_ENV = 'NODE_ENV';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can all this be encapsulated in a util such as isDevBuild assuming one doesn't already exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Done.

if (process.env[NODE_ENV] === 'development') {
return null;
}

const colors = this.context.colors || mockTheme.colors;
const styles = createStyles(colors);

Expand Down
Loading