Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update bitrise e2e check to not run on forks #10128

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

NicholasEllul
Copy link
Contributor

@NicholasEllul NicholasEllul commented Jun 26, 2024

Description

This pull request updates the bitrise e2e check workflow to only trigger from branches within the MetaMask Mobile repository. This brings it in line with other patterns we see across MetaMask such as in core.

Manual testing steps

Pull request on repository (non-fork)

  1. Look at CI on this pull request
  2. See the successful run of Run Bitrise E2E Check.

Pull Request From Fork

  1. Visit https://github.com/NicholasEllul/metamask-mobile/pull/3
  2. See in the CI output that the run-bitrise-e2e-check was skipped.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicholasEllul NicholasEllul force-pushed the ellul/run-bitrise-workflow branch from c846cc4 to 82597d0 Compare June 26, 2024 20:16
@NicholasEllul NicholasEllul marked this pull request as ready for review June 26, 2024 20:16
@NicholasEllul NicholasEllul requested a review from a team as a code owner June 26, 2024 20:16
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 26, 2024
@NicholasEllul NicholasEllul force-pushed the ellul/run-bitrise-workflow branch from 82597d0 to 8170403 Compare June 26, 2024 20:31
@NicholasEllul NicholasEllul force-pushed the ellul/run-bitrise-workflow branch from 8170403 to 41727e4 Compare June 26, 2024 20:32
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@NicholasEllul NicholasEllul merged commit 275926e into main Jun 26, 2024
32 checks passed
@NicholasEllul NicholasEllul deleted the ellul/run-bitrise-workflow branch June 26, 2024 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@metamaskbot metamaskbot added the release-7.27.0 Issue or pull request that will be included in release 7.27.0 label Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.27.0 Issue or pull request that will be included in release 7.27.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants