-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add tokenList iconUrl to IdentIcon
component
#10163
Conversation
Bitrise builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc732094-b76d-4ac8-b836-4e905ccdba53?tab=artifacts The app slows down significantly with simulations enabled. Waited for about 2 mins for Android and simulations never appeared. iPhone: ios.movSamsung: android.mov |
749aab4
to
552e392
Compare
e062ee5
to
b56bfd7
Compare
Bitrise❌❌❌ Commit hash: 1309941 Note
|
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: 693af59 Note
|
Bitrise QA builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/613024ad-473f-4ac9-bc82-112fa1f68a89?tab=artifacts iPhone15, Samsung S24+ Android: Screen_Recording_20240702_124015_MetaMask-QA.mp4iOS: RPReplay_Final1719938743.MP4 |
Description
This PR aims to add support for
IdentIcon
component to use iconUrl for token entity fromtokenList
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist