Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: address flaky smoke e2e #10219

Merged
merged 12 commits into from
Jul 3, 2024
Merged

test: address flaky smoke e2e #10219

merged 12 commits into from
Jul 3, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Jul 2, 2024 •
edited
Loading

Description

The advanced gas fee tests are flaky on Bitrise. The transactions simulation info modal made the edit gas fee link text outside the viewport. To fix, a scroll to the bottom of the confirmations screen is needed.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Jul 2, 2024
@cortisiko cortisiko self-assigned this Jul 2, 2024
@cortisiko cortisiko linked an issue Jul 2, 2024 that may be closed by this pull request
Fix Swaps tests #10148
Closed
9 tasks
cortisiko added 8 commits July 2, 2024 16:37
@cortisiko
alot of flakiness in the tests is a result of a decline in the perfor…
d64a5b9 
…mance on CI. Instead of tapping on send through the action bar, the test will tap on send in the token overview. No other test is sending through the token overview.
@cortisiko
fix linting
0d98317
@cortisiko
scroll to send button
8ed59cd
@cortisiko
Revert "scroll to send button"
d42f04e 
This reverts commit 8ed59cd.
@cortisiko
Revert "fix linting"
2a0b5eb 
This reverts commit 0d98317.
@cortisiko
Revert "alot of flakiness in the tests is a result of a decline in th…
ce559c0 
…e performance on CI. Instead of tapping on send through the action bar, the test will tap on send in the token overview. No other test is sending through the token overview."

This reverts commit d64a5b9.
@cortisiko
fix advance gas fee test
c8ff18b
@cortisiko
fix linting
0b19f0f
cortisiko
cortisiko commented Jul 3, 2024
View reviewed changes
e2e/fixtures/fixture-builder.js Show resolved Hide resolved
e2e/pages/Send/TransactionConfirmView.js Show resolved Hide resolved
e2e/pages/Send/TransactionConfirmView.js Show resolved Hide resolved
e2e/resources/networks.e2e.js Show resolved Hide resolved
e2e/resources/networks.e2e.js Show resolved Hide resolved
e2e/specs/settings/fiat-on-testnets.spec.js Show resolved Hide resolved
@cortisiko cortisiko marked this pull request as ready for review July 3, 2024 03:20
@cortisiko cortisiko requested a review from a team as a code owner July 3, 2024 03:20
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fb4d3e5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5d37751-f8ca-415a-a052-9e0571637c45

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 3, 2024
@OGPoyraz OGPoyraz merged commit ca43521 into main Jul 3, 2024
46 of 47 checks passed
@OGPoyraz OGPoyraz deleted the detox/fix-swaps-smoke-e2e branch July 3, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@metamaskbot metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees

@cortisiko cortisiko

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.27.1 Issue or pull request that will be included in release 7.27.1 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Swaps tests
4 participants
@cortisiko @OGPoyraz @owencraston @metamaskbot