Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add edge case of having falsy address for useTokenListEntries #10227

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jul 2, 2024

Description

This PR adds the support of having falsy address for useTokenListEntries hook.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz changed the title Add edge case of having falsy address for useTokenListEntries fix: Add edge case of having falsy address for useTokenListEntries Jul 2, 2024
@OGPoyraz OGPoyraz changed the title fix: Add edge case of having falsy address for useTokenListEntries fix: add edge case of having falsy address for useTokenListEntries Jul 2, 2024
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 2, 2024
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 2, 2024
@OGPoyraz OGPoyraz marked this pull request as ready for review July 2, 2024 23:00
@OGPoyraz OGPoyraz requested a review from a team as a code owner July 2, 2024 23:00
Copy link
Contributor

github-actions bot commented Jul 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 77ed425
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2eff58a4-672a-4792-88f9-a42de63fb510

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Jul 2, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.68%. Comparing base (ea14ef7) to head (77ed425).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10227      +/-   ##
==========================================
+ Coverage   49.50%   49.68%   +0.17%     
==========================================
  Files        1438     1444       +6     
  Lines       34674    34738      +64     
  Branches     3853     3858       +5     
==========================================
+ Hits        17166    17258      +92     
+ Misses      16426    16397      -29     
- Partials     1082     1083       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
@OGPoyraz OGPoyraz merged commit b3ea18b into main Jul 3, 2024
51 of 54 checks passed
@OGPoyraz OGPoyraz deleted the fix/e2e-identicon-issue branch July 3, 2024 00:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@metamaskbot metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.27.1 Issue or pull request that will be included in release 7.27.1 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants