Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alternative edge case test for having falsy address for Identicon #10229

Closed
wants to merge 1 commit into from

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jul 2, 2024

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners July 2, 2024 23:12
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 2, 2024
@OGPoyraz OGPoyraz changed the title [DO NOT MERGE] alternative edge case test for having falsy address for identicon fix: alternative edge case test for having falsy address for Identicon Jul 2, 2024
@OGPoyraz OGPoyraz added the DO-NOT-MERGE Pull requests that should not be merged label Jul 2, 2024
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2b191af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a15e785-ceed-46cc-824a-c01a70d37d38

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz closed this Jul 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO-NOT-MERGE Pull requests that should not be merged Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants