-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip blockaid validations for users internal accounts #10264
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 79ea9c5 Note
|
Bitrise❌❌❌ Commit hash: f31edca Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting minor update to test before merge
Bitrise✅✅✅ Commit hash: 41a66bf Note
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10264 +/- ##
==========================================
+ Coverage 49.67% 49.70% +0.03%
==========================================
Files 1450 1451 +1
Lines 34888 34919 +31
Branches 3950 3955 +5
==========================================
+ Hits 17330 17356 +26
- Misses 16456 16459 +3
- Partials 1102 1104 +2 ☔ View full report in Codecov by Sentry. |
Description
Skip blockaid validation for users internal accounts
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2633
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist