Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added isScaled option to BadgeNetwork to allow nonscaled usage #10321

Merged
merged 5 commits into from
Jul 17, 2024
Merged

chore: added isScaled option to BadgeNetwork to allow nonscaled usage #10321

merged 5 commits into from
Jul 17, 2024

Conversation

brianacnguyen
Copy link
Contributor

Description

  • This PR seeks to add isScaled option to BadgeNetwork to accommodate for the new NFT design, which requires that the Badge does not scale with the NFT
  • Also adds more tests and update the stories

Related issues

Fixes: #10320

Manual testing steps

  1. Go to storybook
  2. Check out BadgeNetwork

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-15.at.16.11.26.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 16, 2024
@brianacnguyen brianacnguyen self-assigned this Jul 16, 2024
@brianacnguyen brianacnguyen requested review from a team as code owners July 16, 2024 15:31
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2aa6836
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f2c2abc-90bd-4acf-bdea-950ca3a96b30

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen requested review from a team as code owners July 16, 2024 17:07
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1c17405
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c1adb27-fc3a-4bf9-be56-8468d00bd71b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c465d8c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b94b57f1-7b15-4b82-a682-945cbe84d5de

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

georgewrmarshall
georgewrmarshall approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianacnguyen brianacnguyen merged commit 4fdbe46 into main Jul 17, 2024
37 of 38 checks passed
@brianacnguyen brianacnguyen deleted the badge-enhancements branch July 17, 2024 00:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 17, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[chore] Add non-scaled option for BadgeNetwork
4 participants
@brianacnguyen @georgewrmarshall @Cal-L @metamaskbot