Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix TS errors for EditGasFeeLegacyUpdate file #10333

Closed
wants to merge 1 commit into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Description

The aim of this chore is to achieve 100% TypeScript file coverage by fixing all TypeScript issues in the specified files.

/app/components/Views/confirmations/components/EditGasFeeLegacyUpdate/index.tsx:136-147

Changes made:

  • Updated type assertions for gasFeeEstimate to handle different possible types (EthGasPriceEstimate, LegacyGasPriceEstimate, GasFeeEstimates)
  • Added null coalescing operators to provide fallback values
  • Improved type safety by explicitly handling different gas estimate types

Related issues

#10207

Manual testing steps

  • yarn lint:tsc should yield no new or unexpected TypeScript errors

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch; run the app; test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Jul 17, 2024
@metamaskbot metamaskbot added the team-ai AI team (for the Devin AI bot) label Jul 17, 2024
Copy link

@sethkfman sethkfman closed this Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants