Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: abort setup if any of the work on the main task fails #10336

Closed
wants to merge 1 commit into from

Conversation

joaoloureirop
Copy link
Contributor

Abort yarn setup if any of the tasks mentioned below fail.

Lavamoat allow-scripts, CocoaPods install, detox tools install, or env vars setup

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Lavamoat allow-scripts, CocoaPods install,
detox tools install, or env vars setup
@joaoloureirop joaoloureirop self-assigned this Jul 18, 2024
@joaoloureirop joaoloureirop requested a review from a team as a code owner July 18, 2024 10:31
Copy link
Contributor

github-actions bot commented Jul 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@joaoloureirop joaoloureirop changed the title abort setup if any of the work on the main task fails chore: abort setup if any of the work on the main task fails Jul 18, 2024
@joaoloureirop joaoloureirop added team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 18, 2024
Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.78%. Comparing base (4b9f31c) to head (cb93a2e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10336      +/-   ##
==========================================
- Coverage   49.78%   49.78%   -0.01%     
==========================================
  Files        1437     1437              
  Lines       34762    34800      +38     
  Branches     3921     3928       +7     
==========================================
+ Hits        17307    17324      +17     
- Misses      16354    16375      +21     
  Partials     1101     1101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaoloureirop
Copy link
Contributor Author

included in 80b561c

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants