Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add notifications actions selectors - 4/7 #10338

Merged
merged 10 commits into from
Jul 19, 2024
Merged

feat: add notifications actions selectors - 4/7 #10338

merged 10 commits into from
Jul 19, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR implements Actions, Selections, and utils for the upcoming Notifications feature. No UI change is presented on this PR.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer requested review from a team as code owners July 18, 2024 11:42
@Jonathansoufer Jonathansoufer self-assigned this Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer added team-mobile-platform team-notifications Notifications team No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 18, 2024
@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9cddf33
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7301bac5-6e2c-4d7f-8321-29fed7a9cc59

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 55032d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70a62a7b-fc63-499e-911c-04a53f04c033

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L reviewed Jul 18, 2024
View reviewed changes
app/actions/notification/pushNotifications.ts Outdated Show resolved Hide resolved
app/util/notifications/notification.util.ts Outdated Show resolved Hide resolved
app/util/notifications/notification.util.ts Outdated Show resolved Hide resolved
app/util/notifications/notification.util.ts Outdated Show resolved Hide resolved
app/util/notifications/push-permissions.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
1 Security Hotspot
5.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansoufer Jonathansoufer merged commit 2f69e5f into main Jul 19, 2024
31 of 32 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/add-notifications-actions-selectors branch July 19, 2024 06:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 19, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jonathansoufer @Cal-L @Prithpal-Sooriya @metamaskbot