Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add privacy query params to Portfolio navigation #10341

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Conversation

julesat22
Copy link
Contributor

@julesat22 julesat22 commented Jul 18, 2024

Description

Added metricsEnabled and marketingEnabled query params to reflect user privacy preferences on navigation to Portfolio. These settings, sent from mobile, will be consumed by the Portfolio to update and align privacy preferences.

Our current privacy opt-in rate has been low since some recent updates to our privacy flow, so we would like to align our privacy settings with the other platforms.

Related issues

Fixes:

Manual testing steps

  1. Go to Tokens page in mm mobile
  2. Navigate to Portfolio (in a new tab, not in one that has already been opened)
  3. See that the privacy params accurately reflect the user's settings in mobile

Example URL:

https://portfolio.metamask.io/?metamaskEntry=mobile&metricsEnabled=false&marketingEnabled=false

Screenshots/Recordings

Before

https://www.loom.com/share/d4034b05e4f7496d9f2ee55416777363

After

With query params attached:

https://www.loom.com/share/4b382b19dcfe460a854ca4f95ebf4819

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@julesat22 julesat22 requested a review from a team as a code owner July 18, 2024 16:33
@julesat22 julesat22 marked this pull request as draft July 18, 2024 16:33
Copy link
Contributor

github-actions bot commented Jul 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@julesat22
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 18, 2024
@julesat22 julesat22 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jul 18, 2024
Copy link
Contributor

github-actions bot commented Jul 18, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c7a7423
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a92a70cf-4a88-4385-bd10-a711066f27ec

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@julesat22 julesat22 marked this pull request as ready for review July 18, 2024 17:48
@julesat22 julesat22 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 18, 2024
Copy link
Contributor

github-actions bot commented Jul 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b36addf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be7d80ec-1be3-462a-9e82-7af2bd2b833d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@julesat22 julesat22 self-assigned this Jul 19, 2024
Copy link

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julesat22 julesat22 merged commit 9746010 into main Jul 22, 2024
35 checks passed
@julesat22 julesat22 deleted the MMPD-1274 branch July 22, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-portfolio
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants