-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add privacy query params to Portfolio navigation #10341
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Bitrise❌❌❌ Commit hash: c7a7423 Note
|
Bitrise✅✅✅ Commit hash: b36addf Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added
metricsEnabled
andmarketingEnabled
query params to reflect user privacy preferences on navigation to Portfolio. These settings, sent from mobile, will be consumed by the Portfolio to update and align privacy preferences.Our current privacy opt-in rate has been low since some recent updates to our privacy flow, so we would like to align our privacy settings with the other platforms.
Related issues
Fixes:
Manual testing steps
Example URL:
https://portfolio.metamask.io/?metamaskEntry=mobile&metricsEnabled=false&marketingEnabled=false
Screenshots/Recordings
Before
https://www.loom.com/share/d4034b05e4f7496d9f2ee55416777363
After
With query params attached:
https://www.loom.com/share/4b382b19dcfe460a854ca4f95ebf4819
Pre-merge author checklist
Pre-merge reviewer checklist