fix: aggregated balance calculation

[bergeron]

Description

Fixes the calculation for how much the aggregated balance changed in the last 1 day.

The fiat price 1 day ago was calculated incorrectly. For example it would calculate:

{"ethFiat1dAgo": 1.2011985977032296, "ethFiat": 1.28, "pricePercentChange1d": -6.156359554435198}

But this is backwards. If the price went down 6% in the last 24 hours, you would have had more fiat $ in the past, not less. This broke further calculations.

Related issues

#10406

Manual testing steps

1. Open a wallet with just eth, no erc20 tokens (or hide them all)
2. Verify the aggregated fiat balance % matches the balance % for ETH in the token list

Screenshots/Recordings

Before

Simplest case: a wallet with just eth. The aggregated balance should match ETH since it's the only token:

After

Matches extension now:

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[salimtb]

i think we need the same fix here , my suggestion is :

// Get the percentage change in token price over the last day
          const tokenPriceChange1d =
            tokenExchangeRates?.[item.address as `0x${string}`]
              ?.pricePercentChange1d;
 // Calculate the token Fiat value from 1 day ago
         const tokenBalance1dAgo = tokenPriceChange1d !== undefined ?
              tokenBalanceFiat / (1 + tokenPriceChange1d / 100) : tokenBalanceFiat

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8601ed6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c20cf4b5-baa3-4081-9401-b76e6ac23bff

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sahar-fehri]

Thanks for the fix! 🙏
Tested this while looking at extension;
Noticed that extension total price percentage is not changing like mobile does as you import new tokens? Can someone else confirm?

test.mov

[salimtb]

Thanks for the fix! 🙏 Tested this while looking at extension; Noticed that extension total price percentage is not changing like mobile does as you import new tokens? Can someone else confirm?

test.mov

hey @sahar-fehri , because the aggregated balance is only implemented on mobile for now

[darkwing]

We need to add tests for this.

[bergeron]

i think we need the same fix here ,

Should be there already, it's fixed for the erc20 token calculation too.

[brianacnguyen]

Not sure how DS was tagged to review this, as it does not touch DS

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ea93248
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc5282b1-702a-4c6a-95ba-f30a1951eca2

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[bergeron]

#10251 changed how accounts are represented. updated this PR to mock differently

[gambinish]

Approving with a couple comments out of curiosity ✅

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8936ed4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e99d17b2-5ac6-43ce-a004-453d178fd892

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

LGTM