Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge main into into chore/provider-middleware-filters-2 #12254

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a399369
chore: upgrade signature controller to remove global network (#11996)
matthewwalsh0 Nov 6, 2024
54bc07f
style: remove tilde from swap return value (#12104)
bfullam Nov 6, 2024
1f885dd
fix: E2E: quarantine import-wallet-account tests (#12197)
chrisleewilcox Nov 6, 2024
753e2ea
fix: @metamask/providers@16, @metamask/json-rpc-middleware-stream@8 (…
legobeat Nov 6, 2024
91757b0
chore: Modify gitignore to include generated ios/plist files (#12209)
gambinish Nov 6, 2024
323c319
chore: refactor methods/add FCM Services 3/3 (#12077)
Jonathansoufer Nov 6, 2024
5ef190f
chore: extend dsl component functionality (#12170)
vinnyhoward Nov 6, 2024
a473989
feat: disable wallet buttons for accounts that cannot sign transactio…
owencraston Nov 6, 2024
6e22952
fix: e2e: use different wallet SRP for non accounts tests (#12217)
chrisleewilcox Nov 7, 2024
e446dc1
fix: add contractBalances as dependency (#12205)
sahar-fehri Nov 7, 2024
b2c9110
fix: Onboarding failing biometrics locks screen for user instead of d…
Daniel-Cross Nov 7, 2024
9b5a1e5
fix: relax network symbol length validation (#11693)
bergeron Nov 7, 2024
0b5af0d
chore: notifications UI update to use FCM services (#12214)
Jonathansoufer Nov 7, 2024
fde99ea
fix: Update `transaction-controller` version (#12228)
OGPoyraz Nov 7, 2024
8d65907
fix: Add migration to fix NotificationServicesController bug (#12219)
Nov 7, 2024
3cd5dd6
fix: added ScrollView to stake confirmation review screen (#12231)
Matt561 Nov 7, 2024
1c27676
feat: display snap name (#11511)
k-g-j Nov 8, 2024
099b3df
feat(2796): permission settings replace some of the mock data by real…
EtherWizard33 Nov 8, 2024
d5df037
chore: udpate LSMinimumSystemVersion (#12121)
NicolasMassart Nov 8, 2024
2af2f67
fix: e2e re-enable notifications android workflow (#12232)
chrisleewilcox Nov 8, 2024
1ec8742
chore: upgrade assets-controllers to v41 (#12178)
sahar-fehri Nov 8, 2024
1b48bbc
feat(3448): header update (#11763)
vinnyhoward Nov 8, 2024
db0f0bf
Merge branch 'main' into chore/provider-middleware-filters-2
legobeat Nov 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,6 @@ docs/assets/termsOfUse.html

# build metadata
android/app/src/main/assets/modules.json

# Google firebase base64 derived configs
**/GoogleService-Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
ACCOUNT_BASE_TEST_ID,
} from './AccountBase.constants';
import styles from './AccountBase.styles';
import { strings } from '../../../../../locales/i18n';
import { AccountBaseProps } from './AccountBase.types';

const AccountBase = ({
Expand Down Expand Up @@ -56,7 +55,7 @@ const AccountBase = ({
variant={TextVariant.BodyMDBold}
style={styles.accountNameLabelText}
>
{strings(accountTypeLabel)}
{accountTypeLabel}
</Text>
</View>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,20 @@ const CellSelectWithMenuMeta = {
control: { type: 'boolean' },
defaultValue: SAMPLE_CELLSELECT_WITH_BUTTON_PROPS.isDisabled,
},
withAvatar: {
control: { type: 'boolean' },
defaultValue: true,
},
showSecondaryTextIcon: {
control: { type: 'boolean' },
defaultValue: true,
},
onTextClick: {
action: 'clicked',
},
},
};

export default CellSelectWithMenuMeta;

export const CellMultiSelectWithMenu = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ const styleSheet = (params: {
tagLabel: {
marginTop: 4,
},
selectedTag: {
backgroundColor: colors.primary.muted,
},
containerRow: {
flexDirection: 'row',
alignItems: 'flex-start',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { TouchableOpacity, TouchableWithoutFeedback, View } from 'react-native';

// External dependencies.
import { useStyles } from '../../hooks';
import Tag from '../../../component-library/components/Tags/Tag';

// Internal dependencies.
import styleSheet from './CellSelectWithMenu.styles';
Expand Down Expand Up @@ -34,6 +35,7 @@ const CellSelectWithMenu = ({
isSelected = false,
children,
withAvatar = true,
showSecondaryTextIcon = true,
...props
}: CellSelectWithMenuProps) => {
const { styles } = useStyles(styleSheet, { style });
Expand Down Expand Up @@ -77,14 +79,27 @@ const CellSelectWithMenu = ({
>
{secondaryText}
</Text>
<Icon
name={IconName.ArrowDown}
size={IconSize.Xss}
style={styles.arrowStyle}
/>
{showSecondaryTextIcon && (
<Icon
name={IconName.ArrowDown}
size={IconSize.Xss}
style={styles.arrowStyle}
/>
)}
</TouchableOpacity>
</TouchableWithoutFeedback>
)}
{!!tagLabel && (
<Tag
testID={CellModalSelectorsIDs.TAG_LABEL}
label={tagLabel}
style={
isSelected
? [styles.tagLabel, styles.selectedTag]
: styles.tagLabel
}
/>
)}
</View>
{children && <View style={styles.optionalAccessory}>{children}</View>}
</View>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,37 @@ exports[`CellSelectWithMenu should render with default settings correctly 1`] =
width={10}
/>
</TouchableOpacity>
<View
style={
{
"backgroundColor": "#ffffff",
"borderColor": "#bbc0c5",
"borderRadius": 10,
"borderWidth": 1,
"height": 24,
"justifyContent": "center",
"marginTop": 4,
"paddingHorizontal": 4,
}
}
testID="celltag-label"
>
<Text
accessibilityRole="text"
style={
{
"color": "#141618",
"fontFamily": "EuclidCircularB-Regular",
"fontSize": 14,
"fontWeight": "400",
"letterSpacing": 0,
"lineHeight": 22,
}
}
>
Imported
</Text>
</View>
</View>
</View>
</View>
Expand All @@ -288,7 +319,7 @@ exports[`CellSelectWithMenu should render with default settings correctly 1`] =
<View
style={
{
"paddingHorizontal": 20,
"paddingRight": 20,
}
}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ import Text, {

// Internal dependencies.
import { default as ListItemSelectWithButtonComponent } from './ListItemMultiSelectButton';
import { SAMPLE_LISTITEMMULTISELECT_PROPS } from './ListItemMultiSelectButton.constants';
import {
BUTTON_TEST_ID,
DEFAULT_LISTITEMMULTISELECT_GAP,
SAMPLE_LISTITEMMULTISELECT_PROPS,
} from './ListItemMultiSelectButton.constants';
import { ListItemMultiSelectButtonProps } from './ListItemMultiSelectButton.types';

const ListItemSelectWithButtonMeta = {
Expand All @@ -29,6 +33,27 @@ const ListItemSelectWithButtonMeta = {
control: { type: 'boolean' },
defaultValue: SAMPLE_LISTITEMMULTISELECT_PROPS.isDisabled,
},
showButtonIcon: {
control: { type: 'boolean' },
defaultValue: true,
},
buttonIcon: {
control: { type: 'select' },
options: Object.values(IconName),
defaultValue: IconName.MoreVertical,
},
gap: {
control: { type: 'number' },
defaultValue: DEFAULT_LISTITEMMULTISELECT_GAP,
},
buttonProps: {
control: 'object',
defaultValue: {
textButton: '',
onButtonClick: () => null,
buttonTestId: BUTTON_TEST_ID,
},
},
},
};
export default ListItemSelectWithButtonMeta;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const styleSheet = (params: {
paddingTop: 32,
},
buttonIcon: {
paddingHorizontal: 20,
paddingRight: 20,
},
});
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const ListItemMultiSelectButton: React.FC<ListItemMultiSelectButtonProps> = ({
<ButtonIcon
iconName={buttonIcon}
iconColor={IconColor.Default}
testID={BUTTON_TEST_ID}
testID={buttonProps?.buttonTestId || BUTTON_TEST_ID}
onPress={buttonProps?.onButtonClick}
accessibilityRole="button"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export interface ListItemMultiSelectButtonProps
*/
showButtonIcon?: boolean;

/**
* Optional button props
*/
buttonProps?: {
/**
* Optional button onClick function
Expand All @@ -50,6 +53,16 @@ export interface ListItemMultiSelectButtonProps
* Optional property to show text button
*/
textButton?: string | null;

/**
* Optional property to show button icon
*/
showButtonIcon?: boolean;

/**
* Optional property for button test ID
*/
buttonTestId?: string;
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`ListItemMultiSelectButton should render correctly with default props 1`
<View
style={
{
"paddingHorizontal": 20,
"paddingRight": 20,
}
}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ export interface CellBaseProps {
* Optional prop to control the style of the CellBase.
*/
style?: StyleProp<ViewStyle> | undefined;

/**
* Optional prop to control the visibility of the secondary text icon.
*/
showSecondaryTextIcon?: boolean;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { StyleSheet, ViewStyle } from 'react-native';

// External dependencies.
import { Theme } from '../../../../util/theme/models';
import { fontStyles } from '../../../../styles/common';

// Internal dependencies.
import { PickerAccountStyleSheetVars } from './PickerAccount.types';
Expand All @@ -24,34 +23,39 @@ const styleSheet = (params: {
const { colors } = theme;
const { style, cellAccountContainerStyle } = vars;
return StyleSheet.create({
base: Object.assign({} as ViewStyle, style) as ViewStyle,
base: {
...(style as ViewStyle),
flexDirection: 'row',
padding: 0,
borderWidth: 0,
},
accountAvatar: {
marginRight: 16,
marginRight: 8,
},
accountAddressLabel: {
color: colors.text.alternative,
textAlign: 'center',
},
cellAccount: {
flex: 1,
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'center',
...cellAccountContainerStyle,
},
accountNameLabel: {
alignItems: 'center',
justifyContent: 'center',
},
accountNameAvatar: {
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'flex-start',
},
accountNameLabelText: {
marginTop: 4,
marginHorizontal: 5,
paddingHorizontal: 5,
...fontStyles.bold,
color: colors.text.alternative,
borderWidth: 1,
borderRadius: 10,
borderColor: colors.border.default,
pickerAccountContainer: {
justifyContent: 'center',
textAlign: 'center',
alignItems: 'center',
},
dropDownIcon: {
marginLeft: 8,
},
});
};
Expand Down
Loading
Loading