Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update input handling in useInputHandler to support BACK key functionality #12567

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Dec 5, 2024

Description

This PR updates the handleKeypadChange function in useInputHandler to allow for better input management. The function now also checks for the 'BACK' key press and allows input only if the total number of digits is within the defined limit. This change improves user experience by enabling backspace functionality while maintaining input constraints.

Related issues

Fixes: STAKE-886

Manual testing steps

  1. Start the app
  2. Go to Earn and input high ETH input such that fiat value is more than 12 digits
  3. Click on currency switch button
  4. Press back button on keypad and it should edit the fiat amount even though the digits are more than 12

Screenshots/Recordings

Before

fiat.conversion.digits.mp4

After

Fix.unresponsive.keypad.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…onality

Updated the `handleKeypadChange` function in `useInputHandler` to allow for better input management. The function now checks for the 'BACK' key press and allows input only if the total number of digits is within the defined limit. This change improves user experience by enabling backspace functionality while maintaining input constraints.
Copy link
Contributor

github-actions bot commented Dec 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Dec 5, 2024
@amitabh94 amitabh94 marked this pull request as ready for review December 5, 2024 06:49
@amitabh94 amitabh94 requested a review from a team as a code owner December 5, 2024 06:49
@amitabh94 amitabh94 added team-stake Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-stake No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 5, 2024
@amitabh94 amitabh94 enabled auto-merge December 5, 2024 06:50
Copy link
Contributor

github-actions bot commented Dec 5, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ce23c57
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e970c211-cdf2-4904-a545-fe5f6943a9f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@amitabh94 amitabh94 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit f771782 Dec 5, 2024
60 of 66 checks passed
@amitabh94 amitabh94 deleted the STAKE-886--fe-fix-back-button-for-high-input branch December 5, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants