chore: bump {gas-fee,network,selected-network,notification-services,profile-sync,signature}-controller

[cryptodev-2s]

Description

We want to ensure that mobile is using the latest versions of all controllers.

• Bump @metamask/ppom-validator from 0.35.1 to 0.36.0 (view changes)
  • There are no notable changes between these versions.
• Bump @metamask/gas-fee-controller from 21.0.0 to 22.0.1 (view changes)
  • There are no notable changes between these versions.
• Bump @metamask/signature-controller from 22.0.0 to 23.1.0 (view changes)
  • There are no notable changes between these versions.
• Bump @metamask/profile-sync-controller from 1.0.0 to 2.0.0 (view changes)
  • There are no notable changes between these versions.
• Bump @metamask/selected-network-controller from 18.0.2 to 19.0.0 (view changes)
  • There are no notable changes between these versions.
• Bump @metamask/network-controller from 21.0.0 to 22.1.0 (view changes)
  • Notable changes in 22.1.0:
    • The NetworkController:networkRemoved messenger event will now be emitted when a network is removed.
    • New messenger actions NetworkController:addNetwork, NetworkController:removeNetwork, and NetworkController:updateNetwork which call the respective controller methods.
    • New lastUpdatedAtproperty to network configurations which will be set to the current time on addition or update
  • Notable changes in 22.0.2:
    • getDefaultNetworkConfigurationsByChainId returns the updated display names for mainnet and linea. Ethereum Mainnet instead of Mainnet, and Linea instead of Linea Mainnet.
• Bump @metamask/notification-services-controller from 0.11.0 to 0.14.0 (view changes)
  • Notable changes in 0.12.0:
    • deleteNotificationsById now publishes NotificationServicesController:notificationsListUpdated
  • Notable changes in 0.12.1:
    • When notifications are disabled, list is now repopulated with Snap notifications

Related issues

Completes https://github.com/MetaMask/MetaMask-planning/issues/3698 (and does more to satisfy peer dependency warnings).
#12383

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	0	222 kB	metamaskbot
npm/@metamask/[email protected]	environment Transitive: network	+1	827 kB	metamaskbot
npm/@metamask/[email protected]	network	0	1.37 MB	metamaskbot
npm/@metamask/[email protected]	None	0	122 kB	metamaskbot
npm/@metamask/[email protected]	network	0	1.18 MB	metamaskbot
npm/@metamask/[email protected]	None	0	134 kB	metamaskbot
npm/@metamask/[email protected]	network	0	294 kB	metamaskbot
npm/[email protected]	None	0	81.8 kB	acubed

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected]

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1ab7128
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d46231b-e5be-4ea4-8a4b-bde2a8639f4b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[Gudahtt]

Looks like there is another draft for this as well: #12565

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c8feff7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/864963a6-79dc-42b1-a6a2-4dc2e6dbc345

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2446b55
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/664aff2f-84f5-4a6f-a875-387a2fde1d91

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 260c9ff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cbb252bc-ba9b-4959-a146-b6e48ff07dcd

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd37878
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/904c0ae5-a354-4633-b2c7-9c48640c1f94

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Gudahtt]

It looks like this PR only introduces two new peer dependency warnings:

warning " > @metamask/[email protected]" has incorrect peer dependency "@metamask/gas-fee-controller@^21.0.0".
warning " > @metamask/[email protected]" has incorrect peer dependency "@metamask/network-controller@^21.1.0".

I see that @metamask/[email protected] would address those two warnings, but it involved a number of breaking changes that maybe would be better handled in a separate PR.

I can confirm that these peer dependency mismatches won't cause any problems. For the gas-fee-controller one, none of the types used by the swaps-controller were changed, and the fetchGasFeeEstimates function used has not changed. For network-controller, the swaps-controller was actually using a deprecated release with those breaking changes already present, so there is in fact no additional breaking change here.

[Gudahtt]

LGTM!