Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md with new expo instructions #12617

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Dec 9, 2024

Description

Adding new instructions for Expo:

For internal developers

  • Access Runway via Okta and go to the Expo bucket either on the iOS or Android section. From there you will see the available development builds (android-expo-dev-build.apk or ios-expo-dev-build.ipa).
  • For Android:
    • Install the .apk on your Android device or simulator.
  • For iOS:
    • Device: you need to have your iPhone registered with our Apple dev account. If you have it, you can install the .ipa on your device.
    • Simulator: please follow the native development section and run yarn setup and yarn start:ios as the .ipa will not work for now, we are working on having an .app that works on simulators.
[SOON] For external developers (we are testing the new dev builds and will make them publicly available soon after)

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@andrepimenta andrepimenta marked this pull request as ready for review December 9, 2024 20:07
@andrepimenta andrepimenta requested a review from a team as a code owner December 9, 2024 20:07
@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 9, 2024
@andrepimenta andrepimenta added No QA Needed Apply this label when your PR does not need any QA effort. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Dec 9, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepimenta andrepimenta added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Dec 9, 2024
@andrepimenta andrepimenta changed the title Update README.md with new expo instructions [docs] Update README.md with new expo instructions Dec 9, 2024
@andrepimenta andrepimenta changed the title [docs] Update README.md with new expo instructions docs: Update README.md with new expo instructions Dec 9, 2024
Copy link

sonarqubecloud bot commented Dec 9, 2024

@andrepimenta andrepimenta added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit d2ad6fd Dec 9, 2024
59 of 71 checks passed
@andrepimenta andrepimenta deleted the update-expo-instructions branch December 9, 2024 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants