Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable flaky tests on incoming-transactions.spec #12663

Merged
merged 1 commit into from
Dec 12, 2024
+175 −160
Merged

fix: disable flaky tests on incoming-transactions.spec #12663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
335 changes: 175 additions & 160 deletions e2e/specs/wallet/incoming-transactions.spec.js
View file
Open in desktop
chrisleewilcox marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import { loginToApp } from '../../viewHelper';
import Assertions from '../../utils/Assertions';
import { startMockServer, stopMockServer } from '../../api-mocking/mock-server';
import { withFixtures } from '../../fixtures/fixture-helper';
import FixtureBuilder, { DEFAULT_FIXTURE_ACCOUNT } from '../../fixtures/fixture-builder';
import FixtureBuilder, {
DEFAULT_FIXTURE_ACCOUNT,
} from '../../fixtures/fixture-builder';
import ActivitiesView from '../../pages/Transactions/ActivitiesView';
import TabBarComponent from '../../pages/wallet/TabBarComponent';
import ToastModal from '../../pages/wallet/ToastModal';
Expand All @@ -14,189 +16,202 @@ const TOKEN_SYMBOL_MOCK = 'ABC';
const TOKEN_ADDRESS_MOCK = '0x123';

const RESPONSE_STANDARD_MOCK = {
hash: '0x123456',
timestamp: new Date().toISOString(),
chainId: 1,
blockNumber: 1,
blockHash: '0x2',
gas: 1,
gasUsed: 1,
gasPrice: '1',
effectiveGasPrice: '1',
nonce: 1,
cumulativeGasUsed: 1,
methodId: null,
value: '1230000000000000000',
to: DEFAULT_FIXTURE_ACCOUNT.toLowerCase(),
from: '0x2',
isError: false,
valueTransfers: [],
hash: '0x123456',
timestamp: new Date().toISOString(),
chainId: 1,
blockNumber: 1,
blockHash: '0x2',
gas: 1,
gasUsed: 1,
gasPrice: '1',
effectiveGasPrice: '1',
nonce: 1,
cumulativeGasUsed: 1,
methodId: null,
value: '1230000000000000000',
to: DEFAULT_FIXTURE_ACCOUNT.toLowerCase(),
from: '0x2',
isError: false,
valueTransfers: [],
};

const RESPONSE_STANDARD_2_MOCK = {
...RESPONSE_STANDARD_MOCK,
timestamp: new Date().toISOString(),
hash: '0x2',
value: '2340000000000000000',
...RESPONSE_STANDARD_MOCK,
timestamp: new Date().toISOString(),
hash: '0x2',
value: '2340000000000000000',
};

const RESPONSE_TOKEN_TRANSFER_MOCK = {
...RESPONSE_STANDARD_MOCK,
to: '0x2',
valueTransfers: [
{
contractAddress: TOKEN_ADDRESS_MOCK,
decimal: 18,
symbol: TOKEN_SYMBOL_MOCK,
from: '0x2',
to: DEFAULT_FIXTURE_ACCOUNT.toLowerCase(),
amount: '4560000000000000000',
},
],
...RESPONSE_STANDARD_MOCK,
to: '0x2',
valueTransfers: [
{
contractAddress: TOKEN_ADDRESS_MOCK,
decimal: 18,
symbol: TOKEN_SYMBOL_MOCK,
from: '0x2',
to: DEFAULT_FIXTURE_ACCOUNT.toLowerCase(),
amount: '4560000000000000000',
},
],
};

const RESPONSE_OUTGOING_TRANSACTION_MOCK = {
...RESPONSE_STANDARD_MOCK,
to: '0x2',
from: DEFAULT_FIXTURE_ACCOUNT.toLowerCase(),
...RESPONSE_STANDARD_MOCK,
to: '0x2',
from: DEFAULT_FIXTURE_ACCOUNT.toLowerCase(),
};

function mockAccountsApi(transactions) {
return {
urlEndpoint: `https://accounts.api.cx.metamask.io/v1/accounts/${DEFAULT_FIXTURE_ACCOUNT}/transactions?networks=0x1&sortDirection=ASC`,
response: {
data: transactions ?? [RESPONSE_STANDARD_MOCK, RESPONSE_STANDARD_2_MOCK],
pageInfo: {
count: 2,
hasNextPage: false
}
},
responseCode: 200,
};
return {
urlEndpoint: `https://accounts.api.cx.metamask.io/v1/accounts/${DEFAULT_FIXTURE_ACCOUNT}/transactions?networks=0x1&sortDirection=ASC`,
response: {
data: transactions ?? [RESPONSE_STANDARD_MOCK, RESPONSE_STANDARD_2_MOCK],
pageInfo: {
count: 2,
hasNextPage: false,
},
},
responseCode: 200,
};
}

describe(SmokeCore('Incoming Transactions'), () => {
beforeAll(async () => {
jest.setTimeout(2500000);
await TestHelpers.reverseServerPort();
});

beforeAll(async () => {
jest.setTimeout(2500000);
await TestHelpers.reverseServerPort();
});

it('displays standard incoming transaction', async () => {
await withFixtures(
{
fixture: new FixtureBuilder().build(),
restartDevice: true,
testSpecificMock: {
GET: [mockAccountsApi()]
}
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfTextIsDisplayed('Received ETH');
await Assertions.checkIfTextIsDisplayed(/.*1\.23 ETH.*/);
await Assertions.checkIfTextIsDisplayed(/.*2\.34 ETH.*/);
}
);
});
it('displays standard incoming transaction', async () => {
await withFixtures(
{
fixture: new FixtureBuilder().build(),
restartDevice: true,
testSpecificMock: {
GET: [mockAccountsApi()],
},
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfTextIsDisplayed('Received ETH');
await Assertions.checkIfTextIsDisplayed(/.*1\.23 ETH.*/);
await Assertions.checkIfTextIsDisplayed(/.*2\.34 ETH.*/);
},
);
});

it('displays incoming token transfers', async () => {
await withFixtures(
it('displays incoming token transfers', async () => {
await withFixtures(
{
fixture: new FixtureBuilder()
.withTokens([
{
fixture: new FixtureBuilder().withTokens([{
address: TOKEN_ADDRESS_MOCK, decimals: 18, symbol: TOKEN_SYMBOL_MOCK
}]).build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi([RESPONSE_TOKEN_TRANSFER_MOCK])] }
address: TOKEN_ADDRESS_MOCK,
decimals: 18,
symbol: TOKEN_SYMBOL_MOCK,
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfTextIsDisplayed('Received ABC');
await Assertions.checkIfTextIsDisplayed(/.*4\.56 ABC.*/);
}
);
});
])
.build(),
restartDevice: true,
testSpecificMock: {
GET: [mockAccountsApi([RESPONSE_TOKEN_TRANSFER_MOCK])],
},
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfTextIsDisplayed('Received ABC');
await Assertions.checkIfTextIsDisplayed(/.*4\.56 ABC.*/);
},
);
});

it('displays outgoing transactions', async () => {
await withFixtures(
{
fixture: new FixtureBuilder().build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi([RESPONSE_OUTGOING_TRANSACTION_MOCK])] }
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfTextIsDisplayed('Sent ETH');
await Assertions.checkIfTextIsDisplayed(/.*1\.23 ETH.*/);
}
);
});
xit('displays outgoing transactions', async () => {
chrisleewilcox marked this conversation as resolved.
Show resolved Hide resolved
await withFixtures(
{
fixture: new FixtureBuilder().build(),
restartDevice: true,
testSpecificMock: {
GET: [mockAccountsApi([RESPONSE_OUTGOING_TRANSACTION_MOCK])],
},
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfTextIsDisplayed('Sent ETH');
await Assertions.checkIfTextIsDisplayed(/.*1\.23 ETH.*/);
},
);
});

it('displays nothing if incoming transactions disabled', async () => {
await withFixtures(
{
fixture: new FixtureBuilder()
.withIncomingTransactionPreferences({
'0x1': false
})
.build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi()] }
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await TestHelpers.delay(2000);
await Assertions.checkIfTextIsNotDisplayed('Received ETH');
}
);
});
it('displays nothing if incoming transactions disabled', async () => {
await withFixtures(
{
fixture: new FixtureBuilder()
.withIncomingTransactionPreferences({
'0x1': false,
})
.build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi()] },
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await TestHelpers.delay(2000);
await Assertions.checkIfTextIsNotDisplayed('Received ETH');
},
);
});

it('displays nothing if incoming transaction is a duplicate', async () => {
await withFixtures(
it('displays nothing if incoming transaction is a duplicate', async () => {
await withFixtures(
{
fixture: new FixtureBuilder()
.withTransactions([
{
fixture: new FixtureBuilder()
.withTransactions([{
hash: RESPONSE_STANDARD_MOCK.hash,
txParams: {
from: RESPONSE_STANDARD_MOCK.from
}
}])
.build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi([RESPONSE_STANDARD_MOCK])] }
hash: RESPONSE_STANDARD_MOCK.hash,
txParams: {
from: RESPONSE_STANDARD_MOCK.from,
},
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await TestHelpers.delay(2000);
await Assertions.checkIfTextIsNotDisplayed('Received ETH');
}
);
});
])
.build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi([RESPONSE_STANDARD_MOCK])] },
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await TestHelpers.delay(2000);
await Assertions.checkIfTextIsNotDisplayed('Received ETH');
},
);
});

it('displays notification', async () => {
await withFixtures(
{
fixture: new FixtureBuilder()
.build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi()] }
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfElementToHaveText(await ToastModal.notificationTitle, 'You received 1.23 ETH');
}
xit('displays notification', async () => {
chrisleewilcox marked this conversation as resolved.
Show resolved Hide resolved
await withFixtures(
{
fixture: new FixtureBuilder().build(),
restartDevice: true,
testSpecificMock: { GET: [mockAccountsApi()] },
},
async () => {
await loginToApp();
await TabBarComponent.tapActivity();
await ActivitiesView.swipeDown();
await Assertions.checkIfElementToHaveText(
await ToastModal.notificationTitle,
'You received 1.23 ETH',
);
});
},
);
});
});
Loading