fix: small refactoring of the latest migration script + add a new migration case

[dan437]

Description

Little follow up on this one: #12664

Main thing is to also mark a regular transaction as failed if the STX status was resolved. It's very rare (like the unknown state), but we want to handle such case as well.

Related issues

Fixes:

Manual testing steps

1. Cancelled transaction stuck thanks to super low gas settings
2. All other submitted transactions afterwards as well with the invalid_nonce error.
3. Upgrade to 7.37.1 and see all cancelled tx
4. Try a new tx

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d85f8b6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d9001fa-76fc-42c6-ab30-7441d0a8fa25

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sethkfman]

LGTM