Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(3598): fixing some failing e2e tests possibly due to flakiness introduced by toast sticking around longer than should #12695

Merged
merged 7 commits into from
Dec 13, 2024
Merged

test(3598): fixing some failing e2e tests possibly due to flakiness introduced by toast sticking around longer than should #12695

merged 7 commits into from
Dec 13, 2024
+19 −5

Conversation

EtherWizard33
Copy link
Contributor

Description

WIP

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 942a3fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4378962a-adcb-4b2d-b3d9-55c68709a015

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33
Revert "fix(3598): Strengthen the check for fallback network switchin…
40d0235 
…g in the scenario where user unchecked the active chain."

This reverts commit 6484062.
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 40d0235
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d48d9a2-13ad-4d17-9c8b-111a1e54a08e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@EtherWizard33
Revert "Revert "fix(3598): Strengthen the check for fallback network …
630e1fd 
…switching in the scenario where user unchecked the active chain.""

This reverts commit 40d0235.
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 630e1fd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ad60bd90-061a-4204-ab4f-5baa2c4ee4ae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@EtherWizard33 EtherWizard33 marked this pull request as ready for review December 13, 2024 16:10
@EtherWizard33 EtherWizard33 requested review from a team as code owners December 13, 2024 16:10
@EtherWizard33 EtherWizard33 changed the title test(3598): WIP, fixing some failing e2e tests possibly due to flakiness introduced by toast sticking around longer than should, test(3598): fixing some failing e2e tests possibly due to flakiness introduced by toast sticking around longer than should Dec 13, 2024
@EtherWizard33
Merge branch 'main' into ci-only-fix-3598-strengten-the-check-for-fal…
7fbad8f 
…lback-network-2-fix-switching-to-permitted-and-fallback-test-fix-attemp
vinnyhoward
vinnyhoward approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 8aece87 Dec 13, 2024
35 of 36 checks passed
@EtherWizard33 EtherWizard33 deleted the ci-only-fix-3598-strengten-the-check-for-fallback-network-2-fix-switching-to-permitted-and-fallback-test-fix-attemp branch December 13, 2024 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EtherWizard33 @cortisiko @vinnyhoward @metamaskbot