Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump @metamask/smart-transactions-controller to 16.0.0 #12790

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore: bump @metamask/smart-transactions-controller to 16.0.0 #12790

merged 1 commit into from
Dec 19, 2024
+5 −6

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Dec 19, 2024 •
edited
Loading

Description

This PR bumps @metamask/smart-transactions-controller to 16.0.0 CHANGELOG

  • @metamask/transaction-controller has been bumped to 42.0.0 which match the current version used in the client.

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s added team-wallet-framework Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@cryptodev-2s cryptodev-2s self-assigned this Dec 19, 2024
@cryptodev-2s cryptodev-2s requested review from a team as code owners December 19, 2024 11:33
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s requested a review from dan437 December 19, 2024 11:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a4c223e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef63de9f-31c6-4d48-9c2f-e393f9ce3c6f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network +4 2.23 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Gudahtt
Gudahtt approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 4b9ea55 Dec 19, 2024
56 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-smart-transactions-controller-16.0.0 branch December 19, 2024 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@dan437 dan437 Awaiting requested review from dan437

Assignees

@cryptodev-2s cryptodev-2s

Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cryptodev-2s @Gudahtt @tommasini @metamaskbot