Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): move multichain assets test so it runs as part of the assets bitrise workflow #12807

Merged

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Dec 20, 2024

Description

This moves the mutlichain assets test to the assets workflow. The multichain workflow still has 6 more tests to add and already reached over 20 minutes run, which is close to or over the expected length, while assets workflow was using only 7min of it's workflow.

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Dec 20, 2024
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner December 20, 2024 10:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 216c561
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e86f1ff-ce44-48ad-b176-4e57b6981329

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@EtherWizard33 EtherWizard33 changed the title chore(tests): move multichain assets test so it runs as part of the a… chore(tests): move multichain assets test so it runs as part of the assets bitrise workflow Dec 20, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅ ✅

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 89b61d3 Dec 20, 2024
50 of 51 checks passed
@EtherWizard33 EtherWizard33 deleted the test/move-the-multichain-assets-test-to-assets-folder branch December 20, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e2e-test release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants