Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated default button label text variant to bodyMDMedium #12816

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Dec 20, 2024

Description

Updated the <Button/> label default TextVariant to be TextVariant.BodyMDMedium to reflect the current design system version.

Design

https://www.figma.com/design/HKpPKij9V3TpsyMV1TpV7C/DS-Components?m=auto&node-id=15196-36818

image

Manual testing steps

Note: This is a change to the component-library Button and should be visible globally.

Specific Location to Test:

  1. From the asset list (home screen), select Ethereum.
  2. The "stake" (if you don't have any staked positions) or "unstake" and "stake more" (if you have staked positions) button labels should be using TextVariant.BodyMDMedium.

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added team-design-system All issues relating to design system in Mobile and removed team-identity labels Dec 20, 2024
@Matt561 Matt561 marked this pull request as ready for review December 20, 2024 17:12
@Matt561 Matt561 requested review from a team as code owners December 20, 2024 17:12
@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c14d18f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e62e10c9-b80e-4456-a1e3-8e673767bfca

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 20, 2024
@Matt561 Matt561 force-pushed the fix/update-default-button-base-label-text-variant branch from c14d18f to a93956b Compare December 20, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants