Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: toggle token detection when basic functionality is toggled #12964

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bergeron
Copy link
Contributor

Description

Toggles token detection setting when the basic functionality is toggled. Consistent with extension behavior.

Related issues

Fixes:

Manual testing steps

  1. Disable basic functionality in security/privacy settings
  2. Verify token detection gets disabled in advanced settings
  3. Enable basic functionality
  4. Verify token detection gets enabled

Screenshots/Recordings

Before

Screen.Recording.2025-01-13.at.11.46.59.AM.mov

After

Screen.Recording.2025-01-13.at.11.47.35.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner January 13, 2025 19:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9c12f56
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a724eede-57cf-4569-b1d1-54b35dd3cf5a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 16, 2025
@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 38ed9b9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db736328-4efb-4d64-940f-f3dd0470ad78

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants