fix: fix old signature e2e by mocking launch darkly api

[jpuri]

Description

Fix old signature pages e2e. by mocking launch darkly api.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3916

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2dc7aa9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4a7e8198-b918-4d05-99d0-b7fb1d314160

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[cortisiko]

Seems like https://github.com/MetaMask/metamask-mobile/blob/e2e_fix/e2e/specs/confirmations/signatures/ethereum-sign.spec.js was missed?

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1227bb4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a84d3039-621d-43ba-91fa-47849e9ea0d8

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[jpuri]

Seems like https://github.com/MetaMask/metamask-mobile/blob/e2e_fix/e2e/specs/confirmations/signatures/ethereum-sign.spec.js was missed?

Hey @cortisiko : eth sign is deprecated and not covered by new designs.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cf8d4da
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be58bce9-f0b0-4f55-a188-907565f9d1bb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[cortisiko]

Thanks for addressing @jpuri , we will get the test name/variables updated to reflect its true intent

[digiwand]

discussed w/ @jpuri about removing REDESIGN_SIGNATURE_REQUEST flag from jest.config.js. not a blocker and will be done in a follow-up PR

Lgtm!

[cortisiko]

wait, it seems like the ios_api_specs workflow is consistently failing on this PR: https://app.bitrise.io/app/be69d4368ee7e86d?branch=e2e_fix can we take a look @jpuri if we merge this is going to break main

My recommendation is trying running the tests locally to get an understanding of what is going on

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 24de5c5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/62915f2a-c64c-4850-8d7b-aba93c7c0667

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud