Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix disappearing security alert response #13027

Merged

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to retain securityAlertResponses on SET_TRANSACTION_OBJECT action.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3903

Manual testing steps

  1. Open up our [MetaMask E2E test dapp](https://metamask.github.io/test-dapp/) and attempt to prompt a malicious approval for BUSD in our PPOM section.
  2. Notice that the malicious warning might popup and stay on screen.

Screenshots/Recordings

retain.security.alert.responses.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner January 16, 2025 10:36
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 16, 2025
@OGPoyraz OGPoyraz added No E2E Smoke Needed If the PR does not need E2E smoke test run needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 16, 2025
@OGPoyraz OGPoyraz changed the title fix: Fix hiding security alert response fix: Fix disappearing security alert response Jan 16, 2025
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 16, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 435c9e6 Jan 16, 2025
49 of 53 checks passed
@OGPoyraz OGPoyraz deleted the 3903-blockaid-warning-disappears-on-malicious-confirmation branch January 16, 2025 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 16, 2025
@sleepytanya
Copy link
Contributor

sleepytanya commented Jan 16, 2025

Bitrise build: https://app.bitrise.io/build/014dc33f-f2ff-4e74-a1de-38aea7146600?tab=artifacts

Android:

android.mp4

iOS:

ios.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants