fix: Update siwe parse to v2.1.0

[tommasini]

Description

More info here

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@noble/[email protected]	None	0	773 kB	paulmillr
npm/@spruceid/[email protected]	None	0	36.3 kB	sbihel
npm/[email protected]	filesystem	0	1.45 MB	ldthomas

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@noble/[email protected], npm/@spruceid/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2aca4c2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a355b0f-3b1e-4297-bd42-401c54dfd125

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

Fix dedupe and e2e test failures

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9bbdc14
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/687224a7-e26f-4946-9544-5539701f9745

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[NicholasEllul]

@SocketSecurity ignore npm/@spruceid/[email protected]

[tommasini]

@SocketSecurity ignore-all
After talking with @NicholasEllul, the risks discovered by socket security are acceptable

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f92b0f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a0382d16-c874-4684-a5ff-1b06632f5443

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Cal-L]

LGTM

[digiwand]

looks good to merge!

I created a PR to update the apg-js npm package in the spruceid/siwe repo based on #9247 (comment). If it's merged, we could remove the library from package.json

[digiwand]

The PR mentioned above has been merged and released to @spruceid/[email protected]. We could update the siwe-parser package and remove the apg-js dependency

---

something I was thinking is we might even be able to revert this PR. The reason is because mobile doesn't support SIWE confirmation pages yet and I don't see any use-cases for the siwe-parser in the repo

Mobile ticket to support SIWE: https://github.com/MetaMask/MetaMask-planning/issues/1128

cc: @tommasini @NicholasEllul

[NicholasEllul]

@digiwand great callout, we are reverting the change here and are instead planning on bumping this naturally with the controller upgrades