Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase percentage #9634

Closed
wants to merge 3 commits into from
Closed

feat: increase percentage #9634

wants to merge 3 commits into from

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented May 15, 2024 •
edited
Loading

Description

This pull request introduces a new feature to the MetaMask mobile that enhances user experience by displaying the percentage increase or decrease for each token directly within the UI. This update aims to provide users with immediate visual feedback on the performance of their tokens, helping them make more informed decisions based on recent market trends.

core PR: MetaMask/core#4206
figma: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Wallet-Assets?node-id=1620-23897&t=EJSzfKoFvTJ5LuK0-0

Related issues

Fixes: #9635

Manual testing steps

  1. Go to the wallet view
  2. You should see the percentage of increase/decrease

Screenshots/Recordings

Before

Screenshot 2024-05-15 at 16 54 25

After

Screenshot 2024-05-15 at 16 39 31

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested review from a team as code owners May 15, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb marked this pull request as draft May 15, 2024 14:56
@salimtb salimtb changed the title Feat increase percentage feat: increase percentage May 15, 2024
@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 15, 2024
@salimtb salimtb force-pushed the feat-increase-percentage branch from ba64f5a to 57a7ace Compare May 15, 2024 15:37
@salimtb salimtb marked this pull request as ready for review May 15, 2024 16:22
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 57a7ace
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/539f976a-2a6f-41ac-ae6b-1ac0d2ef1ebd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
@salimtb salimtb force-pushed the feat-increase-percentage branch 2 times, most recently from fb55136 to 18298dc Compare May 16, 2024 09:52
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 18298dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f784f85c-df77-4cd6-9f5c-a56420eb9c9f

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the feat-increase-percentage branch from 18298dc to 95b8fd0 Compare May 16, 2024 10:03
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 95b8fd0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5efb7fe1-c49f-43d7-991a-94d725752ec3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the feat-increase-percentage branch from 95b8fd0 to 7576968 Compare May 16, 2024 10:38
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7576968
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/703edbaf-9bf2-430a-86a1-263f79cbafd5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the feat-increase-percentage branch 2 times, most recently from 3a02a74 to d08208a Compare May 16, 2024 13:38
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d08208a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee3fb08c-e313-49cb-9031-a3b4585d91ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the feat-increase-percentage branch 3 times, most recently from e7d2958 to f4400b0 Compare May 16, 2024 14:59
brianacnguyen
brianacnguyen requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add stories to the AggregatedPercentage and PercentageChange?

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f4400b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a802cc04-9db0-4407-a673-db77cc29d1d1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the feat-increase-percentage branch from f4400b0 to b3722eb Compare May 16, 2024 16:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@salimtb salimtb marked this pull request as draft May 31, 2024 13:46
@salimtb
Copy link
Contributor Author

salimtb commented Jun 27, 2024

PR available here

@salimtb salimtb closed this Jun 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brianacnguyen brianacnguyen brianacnguyen requested changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement increase decrease percentage
2 participants
@salimtb @brianacnguyen