Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): upgrade sdk to 1.28.1 #9652

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 16, 2024

Description

This PR upgrades the Ramp SDK to version 1.28.1.

This version changes the networks chain id type from number to string.
There must be a removal of all of the casting it was done to perform this change keeping backwards compatibility. This will be addressed in an upcoming PR.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1613

Manual testing steps

@bkirb Please test this against Staging and Production environments since they are different as we transition from chainIds numbers to strings Update: These environments are not different anymore

  1. Ramps Flows (Buy & Sell) must not be impacted.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels May 16, 2024
@wachunei wachunei marked this pull request as ready for review May 16, 2024 15:05
@wachunei wachunei requested review from a team as code owners May 16, 2024 15:05
@wachunei wachunei requested a review from a team as a code owner July 4, 2024 19:04
Copy link

sonarqubecloud bot commented Jul 4, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.67%. Comparing base (ea14ef7) to head (9e63300).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9652      +/-   ##
==========================================
+ Coverage   49.50%   49.67%   +0.16%     
==========================================
  Files        1438     1450      +12     
  Lines       34674    34877     +203     
  Branches     3853     3949      +96     
==========================================
+ Hits        17166    17324     +158     
- Misses      16426    16452      +26     
- Partials     1082     1101      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9e63300
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e90b9f0-b51d-46c0-ae85-7aa9fdaf0fb7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Very concise, targeted and well explained PR. Thanks!

@wachunei wachunei removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jul 5, 2024
@wachunei wachunei merged commit c707f74 into main Jul 5, 2024
49 of 50 checks passed
@wachunei wachunei deleted the chore/ramp-upgrade-sdk-1.28.1 branch July 5, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants