-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ramp): upgrade sdk to 1.28.1 #9652
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9652 +/- ##
==========================================
+ Coverage 49.50% 49.67% +0.16%
==========================================
Files 1438 1450 +12
Lines 34674 34877 +203
Branches 3853 3949 +96
==========================================
+ Hits 17166 17324 +158
- Misses 16426 16452 +26
- Partials 1082 1101 +19 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: 9e63300 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Very concise, targeted and well explained PR. Thanks!
Description
This PR upgrades the Ramp SDK to version 1.28.1.
This version changes the networks chain id type from number to string.
There must be a removal of all of the casting it was done to perform this change keeping backwards compatibility. This will be addressed in an upcoming PR.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1613
Manual testing steps
@bkirb Please test this
against Staging and Production environments since they are different as we transition from chainIds numbers to stringsUpdate: These environments are not different anymoreScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist